Merged
Conversation
lukmccall
reviewed
Mar 1, 2024
android/src/main/java/com/swmansion/reanimated/NodesManager.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/reanimated/NodesManager.java
Outdated
Show resolved
Hide resolved
...VersionPatch/ReanimatedUIManager/73/com/swmansion/reanimated/ReanimatedUIManagerFactory.java
Outdated
Show resolved
Hide resolved
tjzel
reviewed
Mar 4, 2024
tjzel
reviewed
Mar 4, 2024
WoLewicki
force-pushed
the
@wolewicki/bridgeless-mode-with-runtime-executor
branch
from
c09e572 to
e5a24cf
Compare
tjzel
requested changes
Mar 20, 2024
Collaborator
tjzel
left a comment
tjzel
left a comment
There was a problem hiding this comment.
I'm adding some more review changes just to not lose those notions, but now I will proceed to split this PR into 0.74 support part and bridgeless part.
android/src/main/java/com/swmansion/reanimated/ReanimatedPackage.java
Outdated
Show resolved
Hide resolved
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Fix some stuff in @WoLewicki's PR #5734. ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. --> --------- Co-authored-by: Wojciech Lewicki <wojciech.lewicki@swmansion.com>
This was referenced Mar 20, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
## Summary This PR is a part of ongoing effort to bring Reanimated to React Native 0.74 with bridgeless mode. It consists of following Pull Requests, which are split for review convenience - but shouldn't be considered separate entities. They have to be merged in the following order: - #5830 - #5815 - #5834 - #5734 ## Test plan :shipit:
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
## Summary This PR is a part of ongoing effort to bring Reanimated to React Native 0.74 with bridgeless mode. It consists of following Pull Requests, which are split for review convenience - but shouldn't be considered separate entities. They have to be merged in the following order: - #5830 - #5815 - #5834 - #5734 ## Test plan :shipit: --------- Co-authored-by: Wojciech Lewicki <wojciech.lewicki@swmansion.com> Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
## Summary This PR is a part of ongoing effort to bring Reanimated to React Native 0.74 with bridgeless mode. It consists of following Pull Requests, which are split for review convenience - but shouldn't be considered separate entities. They have to be merged in the following order: - #5830 - #5815 - #5834 - #5734 ## Test plan :shipit: --------- Co-authored-by: Wojciech Lewicki <wojciech.lewicki@swmansion.com> Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
tjzel
reviewed
Apr 2, 2024
...NativeVersionPatch/ReanimatedUIManager/latest/com/swmansion/reanimated/ReanimatedModule.java
Show resolved
Hide resolved
...NativeVersionPatch/ReanimatedUIManager/latest/com/swmansion/reanimated/ReanimatedModule.java
Show resolved
Hide resolved
WoLewicki
commented
Apr 3, 2024
Member
Author
WoLewicki
left a comment
WoLewicki
left a comment
There was a problem hiding this comment.
I left some more comments. I see you did some more refactoring of the code. It could be done in the follow-up PR, but if you are confident that it works correctly then we can go with it imo 🚀
FabricExample/android/app/src/main/java/com/fabricexample/MainApplication.kt
Show resolved
Hide resolved
piaskowyk
reviewed
Apr 4, 2024
...NativeVersionPatch/ReanimatedUIManager/latest/com/swmansion/reanimated/ReanimatedModule.java
Show resolved
Hide resolved
...NativeVersionPatch/ReanimatedUIManager/latest/com/swmansion/reanimated/ReanimatedModule.java
Show resolved
Hide resolved
piaskowyk
reviewed
Apr 4, 2024
piaskowyk
approved these changes
Apr 5, 2024
tomekzaw
approved these changes
Apr 5, 2024
Member
tomekzaw
left a comment
tomekzaw
left a comment
There was a problem hiding this comment.
Not a big fan of these changes – some of them introduce code duplication and make things unnecessarily complex. We need to push forward with bridgeless mode support so let's merge it and work on it iteratively.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Turns out that majority of work with regards to using `RuntimeExecutor` done in - #5734 can be reverted since `jsCallInvoker` is staying in the API. Thanks to that we can significantly cleanup the code which is helpful for Worklets. ## Test plan I tested the changes on 0.74, 0.75 and 0.76 for Android/iOS Paper/Fabric and all worked well.
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Turns out that majority of work with regards to using `RuntimeExecutor` done in - #5734 can be reverted since `jsCallInvoker` is staying in the API. Thanks to that we can significantly cleanup the code which is helpful for Worklets. ## Test plan I tested the changes on 0.74, 0.75 and 0.76 for Android/iOS Paper/Fabric and all worked well.
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Turns out that majority of work with regards to using `RuntimeExecutor` done in - #5734 can be reverted since `jsCallInvoker` is staying in the API. Thanks to that we can significantly cleanup the code which is helpful for Worklets. ## Test plan I tested the changes on 0.74, 0.75 and 0.76 for Android/iOS Paper/Fabric and all worked well.
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Turns out that majority of work with regards to using `RuntimeExecutor` done in - #5734 can be reverted since `jsCallInvoker` is staying in the API. Thanks to that we can significantly cleanup the code which is helpful for Worklets. ## Test plan I tested the changes on 0.74, 0.75 and 0.76 for Android/iOS Paper/Fabric and all worked well.
r0h0gg6
pushed a commit
to r0h0gg6/react-native-reanimated
that referenced
this pull request
Jul 28, 2025
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Turns out that majority of work with regards to using `RuntimeExecutor` done in - software-mansion#5734 can be reverted since `jsCallInvoker` is staying in the API. Thanks to that we can significantly cleanup the code which is helpful for Worklets. ## Test plan I tested the changes on 0.74, 0.75 and 0.76 for Android/iOS Paper/Fabric and all worked well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR bringing 0.74/bridgeless mode support to the library.